Searched hist:"3 b6ad623" (Results 1 – 1 of 1) sorted by relevance
/qemu/ |
H A D | blockjob.c | 3b6ad623 Thu Feb 25 10:36:33 GMT 2021 Stefano Garzarella <sgarzare@redhat.com> blockjob: report a better error message
When a block job fails, we report strerror(-job->job.ret) error message, also if the job set an error object. Let's report a better error message using error_get_pretty(job->job.err).
If an error object was not set, strerror(-job->ret) is used as fallback, as explained in include/qemu/job.h:
typedef struct Job { ... /** * Error object for a failed job. * If job->ret is nonzero and an error object was not set, it will be set * to strerror(-job->ret) during job_completed. */ Error *err; }
In block_job_query() there can be a transient where 'job.err' is not set by a scheduled bottom half. In that case we use strerror(-job->ret) as it was before.
Suggested-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> Message-Id: <20210225103633.76746-1-sgarzare@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|